Messages in this thread | | | Date | Mon, 10 Jul 2023 10:52:52 +0200 | Subject | Re: Fwd: Need NVME QUIRK BOGUS for SAMSUNG MZ1WV480HCGL-000MV (Samsung SM-953 Datacenter SSD) | From | "Linux regression tracking (Thorsten Leemhuis)" <> |
| |
On 27.06.23 18:10, Keith Busch wrote: > On Mon, Jun 26, 2023 at 08:15:49AM +0700, Bagas Sanjaya wrote: >> See Bugzilla for the full thread. >> >> The reporter had a quirk (see above) that fixed this regression, >> nevertheless I'm adding it to regzbot to make sure it doesn't fall >> through cracks unnoticed: >> >> #regzbot introduced: 86c2457a8e8112f https://bugzilla.kernel.org/show_bug.cgi?id=217593 >> #regzbot title: NVME_QUIRK_BOGUS_NID is needed for SAMSUNG MZ1WV480HCGL-000MV > > These bug reports really should go to the vendors that created the > broken device with non-unique "unique" fields.
I understand that, but I think we need middlemen for that, as I or Bagas don't have the contacts -- and it's IMHO also a bit much too ask us for in general, as regression tracking is hard enough already. At least unless this becomes something that happen regularly, then a list of persons we could contact would be fine I guess. But we simply can't deal with too many subsystem specific special cases.
> It's easy enough for me > to write the quirk patch, but it's not the ideal solution and may harm > devices/firmwares with the same VID:DID that don't have this problem. > Not being the vendor, I'm not in a postition to know that, so CC'ing > some Samsung folks.
Another request came in today, even with a pseudo-patch: https://bugzilla.kernel.org/show_bug.cgi?id=217649
To quote: ``` As with numerous NVMe controllers these days, Samsung's MZAL41T0HBLB-00BL2, which Lenovo builds into their 16ARP8 also suffers from invalid IDs, breaking suspend and hibernate also on the latest kernel 6.4.2.
The following change restores this functionality:
File: root/drivers/nvme/host/pci.c Change:
- { PCI_DEVICE(0x144d, 0xa80b), /* Samsung PM9B1 256G and 512G */ - .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x144d, 0xa80b), /* Samsung PM9B1 256G, 512G and 1TB */ + .driver_data = NVME_QUIRK_BOGUS_NID | + NVME_QUIRK_DISABLE_WRITE_ZEROES, }, ```
Ciao, Thorsten
| |