Messages in this thread | | | Date | Mon, 10 Jul 2023 10:32:10 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH blktests v1 3/3] nvme/{041,042,043,044,045}: Use default hostnqn and hostid |
| |
On Thu, Jul 06, 2023 at 07:06:28PM +0300, Max Gurtovoy wrote: > > > On 20/06/2023 16:27, Daniel Wagner wrote: > > The host might have enabled the udev/systemd auto connect feature. > > This disturbs the blktests for the fc transport. nvme-cli is able > > to distinguish between the different invocations via the --context > > option. In order to get this working we have to use the default > > hostnqn and hostid and not randon generated IDs for every single > > run. > > > > In the bellow tests the hostnqn and hostid are randomly generated for each > test, so how will it disturb the udev/systemd ?
No, random hostnqn should work as well. The only requirement is that the hostnqn(s) used by blktest are unique.
> I'm not sure how will this change fix something and not sure why --context > is mentioned here.
Sorry about that. I should have updated the commit message. A left over from a earlier version.
> Seems like a good explanation to this patch is to used a dedicated hostnqn > and hostid for blktests instead of randomly generate it.
Okay, I'll update the commit message to reflect this. I suppose I could also look into getting rid of the local variables in the tests.
| |