Messages in this thread | | | From | Vitaly Kuznetsov <> | Subject | Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment | Date | Mon, 10 Jul 2023 09:36:33 +0200 |
| |
Zhang Rui <rui.zhang@intel.com> writes:
> The comment of cpu_smt_possible() is not aligned with the changelog of > commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"), > and it is wrong. > > Fix cpu_smt_possible() comment. > > Signed-off-by: Zhang Rui <rui.zhang@intel.com> > --- > kernel/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index 7e8f1b044772..f6811c857102 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -676,7 +676,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu) > return !cpumask_test_cpu(cpu, &cpus_booted_once_mask); > } > > -/* Returns true if SMT is not supported of forcefully (irreversibly) disabled */ > +/* Returns true if SMT is supported and not forcefully (irreversibly) disabled */ > bool cpu_smt_possible(void) > { > return cpu_smt_control != CPU_SMT_FORCE_DISABLED &&
The function must've had a different name in an earlier version of the patch...
Thanks for catching this!
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
-- Vitaly
| |