lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 06/32] mm/page_vma_mapped: delete bogosity in page_vma_mapped_walk()
    Date
    On 8 Jun 2023, at 21:12, Hugh Dickins wrote:

    > Revert commit a7a69d8ba88d ("mm/thp: another PVMW_SYNC fix in
    > page_vma_mapped_walk()"): I was proud of that "Aha!" commit at the time,
    > but in revisiting page_vma_mapped_walk() for pte_offset_map() failure,
    > that block raised a doubt: and it now seems utterly bogus. The prior
    > map_pte() has taken ptl unconditionally when PVMW_SYNC: I must have
    > forgotten that when making the change. It did no harm, but could not
    > have fixed a BUG or WARN, and is hard to reconcile with coming changes.
    >
    > Signed-off-by: Hugh Dickins <hughd@google.com>

    LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

    --
    Best Regards,
    Yan, Zi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-07-11 03:50    [W:5.629 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site