lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH for 6.5] workqueue: Warn attempt to flush system-wide workqueues.
On Fri, Jun 30, 2023 at 09:28:53PM +0900, Tetsuo Handa wrote:
> Based on commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using
> a macro"), all in-tree users stopped flushing system-wide workqueues.
> Therefore, start emitting runtime message so that all out-of-tree users
> will understand that they need to update their code.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

Applied to wq/for-6.6.

> After this patch, flush_workqueue(wq) where wq cannot be determined at build
> time will not get runtime warning. Should we now start checking wq at run time
> so that we get runtime warning when wq is system-wide?

Yeah, we can add an internal flag for these standard workqueues and trigger
warning when somebody tries to flush them.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2023-07-10 22:42    [W:0.042 / U:3.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site