lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 3/4] intel_idle: Use __update_spec_ctrl() in intel_idle_ibrs()
    Date
    When intel_idle_ibrs() is called, it modifies the SPEC_CTRL MSR to 0
    in order disable IBRS. However, the new MSR value isn't reflected in
    x86_spec_ctrl_current which is at odd with the other code that keep track
    of its state in that percpu variable. Use the new __update_spec_ctrl()
    to have the x86_spec_ctrl_current percpu value properly updated.

    Signed-off-by: Waiman Long <longman@redhat.com>
    Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    ---
    drivers/idle/intel_idle.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
    index b930036edbbe..c9479f089037 100644
    --- a/drivers/idle/intel_idle.c
    +++ b/drivers/idle/intel_idle.c
    @@ -182,12 +182,12 @@ static __cpuidle int intel_idle_ibrs(struct cpuidle_device *dev,
    int ret;

    if (smt_active)
    - native_wrmsrl(MSR_IA32_SPEC_CTRL, 0);
    + __update_spec_ctrl(0);

    ret = __intel_idle(dev, drv, index);

    if (smt_active)
    - native_wrmsrl(MSR_IA32_SPEC_CTRL, spec_ctrl);
    + __update_spec_ctrl(spec_ctrl);

    return ret;
    }
    --
    2.31.1
    \
     
     \ /
      Last update: 2023-07-10 21:52    [W:4.187 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site