Messages in this thread | | | Date | Mon, 10 Jul 2023 19:12:38 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] Revert "debugfs, coccinelle: check for obsolete DEFINE_SIMPLE_ATTRIBUTE() usage" |
| |
On Mon, Jul 10, 2023 at 10:06:52AM -0700, Sean Christopherson wrote: > Remove coccinelle's recommendation to use DEFINE_SIMPLE_ATTRIBUTE() > instead of DEFINE_SIMPLE_ATTRIBUTE(). Regardless of whether or not the > "significant overhead" incurred by debugfs_create_file() is actually > meaningful, warnings from the script have led to a rash of low-quality > patches that have sowed confusion and consumed maintainer time for little > to no benefit. There have been no less than four attempts to "fix" KVM, > and a quick search on lore shows that KVM is not alone. > > This reverts commit 5103068eaca290f890a30aae70085fac44cecaf6. > > Link: https://lore.kernel.org/all/87tu2nbnz3.fsf@mpe.ellerman.id.au > Link: https://lore.kernel.org/all/c0b98151-16b6-6d8f-1765-0f7d46682d60@redhat.com > Link: https://lkml.kernel.org/r/20230706072954.4881-1-duminjie%40vivo.com > Link: https://lore.kernel.org/all/Y2FsbufV00jbyF0B@google.com > Link: https://lore.kernel.org/all/Y2ENJJ1YiSg5oHiy@orome > Link: https://lore.kernel.org/all/7560b350e7b23786ce712118a9a504356ff1cca4.camel@kernel.org > Suggested-by: Paolo Bonzini <pbonzini@redhat.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Sean Christopherson <seanjc@google.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |