lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 03/15] spi: Replace if-else-if by bitops and multiplications
On Mon, Jul 10, 2023 at 06:49:20PM +0300, Andy Shevchenko wrote:

> - if (xfer->bits_per_word <= 8)
> - maxsize = maxwords;
> - else if (xfer->bits_per_word <= 16)
> - maxsize = 2 * maxwords;
> - else
> - maxsize = 4 * maxwords;
> -
> + maxsize = maxwords * roundup_pow_of_two(BITS_TO_BYTES(xfer->bits_per_word));

This will change the behaviour if bits_per_word is more than 32. That
is validated out elsewhere but I shouldn't have had to go around
checking the code to confirm that this is the case. This is the sort of
thing that should be highlighted when doing this sort of edge case
stylistic change.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-07-10 18:58    [W:0.254 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site