Messages in this thread | | | Date | Mon, 10 Jul 2023 17:36:27 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode |
| |
On Sat, Jul 08, 2023 at 03:03:19PM +0200, Andreas Kemnade wrote: > Mark Brown <broonie@kernel.org> wrote:
> > Since we already have clock bindings we should use those to configure > > the clocks, there's several drivers that have added this support already > > - look for clock providers.
> ok, looking around: > Just to make sure I am not running in a bad direction: Do you think > tlv320aic32x4{,-clk}.c is a good example? It is ignoring clk_id. > I was mentally bound to have to use clk_id there, so I did not found a good > solution.
Yes, that looks like a good example - the whole thing here is to move away from using clk_id and to using the clock API to specify clocks.
> So I guess I have to configure the chip as a master and using mclk and compare > register dumps with the state we have now and the state after the changes, > additionally to check bclk functionality directly.
You can probably get away with less but it's goot to be thorough. [unhandled content-type:application/pgp-signature] | |