Messages in this thread | | | From | Namhyung Kim <> | Date | Sat, 1 Jul 2023 18:03:30 -0700 | Subject | Re: [PATCH v3] perf evsel amd: Fix IBS error message |
| |
On Sat, Jul 1, 2023 at 11:17 AM Namhyung Kim <namhyung@kernel.org> wrote: > > Hi Ravi, > > On Fri, Jun 30, 2023 at 1:53 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote: > > > > AMD IBS can do per-process profiling[1] and is no longer restricted to > > per-cpu or systemwide only. Remove stale error message. Also, checking > > just exclude_kernel is not sufficient since IBS does not support any > > privilege filters. So include all exclude_* checks. And finally, move > > these checks under tools/perf/arch/x86/ from generic code. > > > > Before: > > $ sudo ./perf record -e ibs_op//k -C 0 > > Error: > > AMD IBS may only be available in system-wide/per-cpu mode. Try > > using -a, or -C and workload affinity > > > > After: > > $ sudo ./perf record -e ibs_op//k -C 0 > > Error: > > AMD IBS doesn't support privilege filtering. Try again without > > the privilege modifiers (like 'k') at the end. > > > > [1] https://git.kernel.org/torvalds/c/30093056f7b2 > > > > Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com> > > Acked-by: Namhyung Kim <namhyung@kernel.org>
Applied to perf-tools-next, thanks!
| |