| Date | Fri, 9 Jun 2023 11:06:02 +0200 | Subject | Re: [PATCH mm-unstable v2 09/10] kvm/x86: add kvm_arch_test_clear_young() | From | Paolo Bonzini <> |
| |
On 5/27/23 01:44, Yu Zhao wrote: > +#define kvm_arch_has_test_clear_young kvm_arch_has_test_clear_young > +static inline bool kvm_arch_has_test_clear_young(void) > +{ > + return IS_ENABLED(CONFIG_X86_64) && > + (!IS_REACHABLE(CONFIG_KVM) || (tdp_mmu_enabled && shadow_accessed_mask)); > +}
I don't think you need IS_REACHABLE(CONFIG_KVM) here, it would be a bug if this is called from outside KVM code.
Maybe make it a BUILD_BUG_ON?
Paolo
|