lkml.org 
[lkml]   [2023]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [v4 1/5] dt-bindings: mfd: Add aspeed pwm-tach binding
From
On 08/06/2023 09:15, Billy Tsai wrote:
> On 23/11/2022 09:24, Krzysztof Kozlowski wrote:
> >> On 23/11/2022 07:16, Billy Tsai wrote:
> >>> Add device binding for aspeed pwm-tach device which is a multi-function
> >>> device include pwm and tach function.
> >>
> >> Subject: drop second, redundant "bindings".
>
> > Where did you implement this comment in your v6?
>
> Sorry, I guess by "Subject: drop second, redundant "bindings"" you meant to remove the second "bindings" string from my subject. So I change the subject from "dt-bindings: hwmon: Add bindings for aspeed tach controller" and "dt-bindings: pwm: Add bindings for aspeed pwm controller" in v4 to "dt-bindings: hwmon: Add ASPEED TACH Control documentation" and "dt-bindings: pwm: Add ASPEED PWM Control documentation" in v6.

A nit, subject: drop second/last, redundant "documentation". The
"dt-bindings" prefix is already stating that these are bindings and
documentation.

> If I have misunderstood your comment, please let me know.

You replaced one redundant with other redundant. I only asked to drop
it, not replace it.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-06-08 09:21    [W:0.105 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site