Messages in this thread | | | Date | Thu, 8 Jun 2023 09:20:08 +0200 | Subject | Re: [v4 1/5] dt-bindings: mfd: Add aspeed pwm-tach binding | From | Krzysztof Kozlowski <> |
| |
On 08/06/2023 09:15, Billy Tsai wrote: > On 23/11/2022 09:24, Krzysztof Kozlowski wrote: > >> On 23/11/2022 07:16, Billy Tsai wrote: > >>> Add device binding for aspeed pwm-tach device which is a multi-function > >>> device include pwm and tach function. > >> > >> Subject: drop second, redundant "bindings". > > > Where did you implement this comment in your v6? > > Sorry, I guess by "Subject: drop second, redundant "bindings"" you meant to remove the second "bindings" string from my subject. So I change the subject from "dt-bindings: hwmon: Add bindings for aspeed tach controller" and "dt-bindings: pwm: Add bindings for aspeed pwm controller" in v4 to "dt-bindings: hwmon: Add ASPEED TACH Control documentation" and "dt-bindings: pwm: Add ASPEED PWM Control documentation" in v6.
A nit, subject: drop second/last, redundant "documentation". The "dt-bindings" prefix is already stating that these are bindings and documentation.
> If I have misunderstood your comment, please let me know.
You replaced one redundant with other redundant. I only asked to drop it, not replace it.
Best regards, Krzysztof
| |