Messages in this thread Patch in this message | | | Date | Thu, 8 Jun 2023 15:31:58 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH] PCI: PM: Extend Elo i2 quirk to all systems using Continental Z2 board |
| |
[+cc Stefan]
s|PCI: PM:|PCI/PM| in the subject to match history.
On Fri, May 19, 2023 at 10:58:53AM +0200, Ondrej Zary wrote: > The quirk for Elo i2 is also needed by EloPOS E2/S2/H2 which uses the > same Continental Z2 board. Change the quirk to match the board instead > of system.
I would mention 92597f97a40b ("PCI/PM: Avoid putting Elo i2 PCIe Ports in D3cold") here since it has more details that might be relevant.
Is there a problem report we can point to here? Oh, I see you chimed in on https://bugzilla.kernel.org/show_bug.cgi?id=215715. Let's include that link here, too.
This also needs a Signed-off-by tag; see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.3#n363
Maybe also a stable tag since 92597f97a40b had one.
After we have the above tweaks, I plan to apply this unless somebody objects.
Bjorn
> --- > drivers/pci/pci.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 5ede93222bc1..c779eb4d7fb8 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -2949,13 +2949,13 @@ static const struct dmi_system_id bridge_d3_blacklist[] = { > { > /* > * Downstream device is not accessible after putting a root port > - * into D3cold and back into D0 on Elo i2. > + * into D3cold and back into D0 on Elo Continental Z2 board > */ > - .ident = "Elo i2", > + .ident = "Elo Continental Z2", > .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "Elo Touch Solutions"), > - DMI_MATCH(DMI_PRODUCT_NAME, "Elo i2"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "RevB"), > + DMI_MATCH(DMI_BOARD_VENDOR, "Elo Touch Solutions"), > + DMI_MATCH(DMI_BOARD_NAME, "Geminilake"), > + DMI_MATCH(DMI_BOARD_VERSION, "Continental Z2"), > }, > }, > #endif > -- > 2.39.2 >
| |