Messages in this thread | | | Date | Tue, 6 Jun 2023 16:32:51 +0530 | Subject | Re: [PATCH v2] cdx: add MSI support for CDX bus | From | Nipun Gupta <> |
| |
On 5/18/2023 5:14 PM, Nipun Gupta wrote: > Add CDX-MSI domain per CDX controller with gic-its domain as > a parent, to support MSI for CDX devices. CDX devices allocate > MSIs from the CDX domain. Also, introduce APIs to alloc and free > IRQs for CDX domain. > > In CDX subsystem firmware is a controller for all devices and > their configuration. CDX bus controller sends all the write_msi_msg > commands to firmware running on RPU and the firmware interfaces with > actual devices to pass this information to devices > > Since, CDX controller is the only way to communicate with the Firmware > for MSI write info, CDX domain per controller required in contrast to > having a CDX domain per device. > > Co-developed-by: Nikhil Agarwal <nikhil.agarwal@amd.com> > Signed-off-by: Nikhil Agarwal <nikhil.agarwal@amd.com> > Co-developed-by: Abhijit Gangurde <abhijit.gangurde@amd.com> > Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com> > Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com> > --- > > Changes v1->v2: > - fixed scenario where msi write was called asyncronously in > an atomic context, by using irq_chip_(un)lock, and using sync > MCDI API for write MSI message. > - fixed broken Signed-off-by chain.
Hi Thomas,
Did you had a chance to look at patch v2. Please let me know in case anything else is required to be updated.
Thanks, Nipun
| |