Messages in this thread | | | From | Paul Moore <> | Date | Tue, 6 Jun 2023 17:13:26 -0400 | Subject | Re: [PATCH v2] LSM: SafeSetID: fix UID printed instead of GID |
| |
On Tue, Jun 6, 2023 at 2:50 PM Aleksandr Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> wrote: > On Thu, May 18, 2023 at 8:59 PM Paul Moore <paul@paul-moore.com> wrote: > > On Wed, May 3, 2023 at 2:44 AM Alexander Mikhalitsyn > > <aleksandr.mikhalitsyn@canonical.com> wrote: > > > > > > pr_warn message clearly says that GID should be printed, > > > but we have UID there. Let's fix that. > > > > > > Found accidentaly during the work on isolated user namespaces. > > > > > > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> > > > --- > > > v2: __kuid_val -> __kgid_val > > > --- > > > security/safesetid/lsm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I'm assuming you're going to pick this up Micah? > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > Dear Paul! > > Thanks for your review! > > Gentle ping to Micah Morton :-)
Micah?
The right thing would be for Micah to merge this via the SafeSetID tree, however, considering that it's been over a month with no response, and this patch looks trivially correct, I can pick this up via the LSM tree if we don't see anything from Micah this week.
-- paul-moore.com
| |