Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 6 Jun 2023 20:17:57 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH V2 1/6] perf/x86/intel: Add Grand Ridge and Sierra Forest |
| |
On Tue, Jun 06, 2023 at 12:16:29PM -0400, Liang, Kan wrote:
> > names for a reason, so that enums like the above become something > > sensible like: > > > > case INTEL_FAM6_ATOM_CRESTMONT: > > case INTEL_FAM6_ATOM_CRESTMONT_X: > > > > and now it's super obvious why they're grouped. > > > >>> + pr_cont("Crestmont events, "); > > The Sierra Forest should not be a platform name. I think it's the code > name of the processor. > > The problem is that the uarch name doesn't work for the hybrid, since it > has different uarchs in the same processors. To make the naming rules > consistent among big core, atom, and hybrid, maybe we should use the > code name of the processor in intel-family.h.
I obviously disagree; these are not hybrid and calling them both CRESTMONT makes *far* more sense than the random gibberish they're called now.
Yes, hybrid made a complete mess of things (in many ways), but we should then not do the obvious correct thing for when we can.
| ![\](/images/icornerr.gif) |