Messages in this thread | | | Date | Tue, 06 Jun 2023 19:42:03 +0300 | From | "Jarkko Sakkinen" <> | Subject | Re: [PATCH 1/2] tpm, tpm_tis: Handle interrupt storm |
| |
On Mon May 29, 2023 at 4:15 PM EEST, Lino Sanfilippo wrote: > > Except that if the line got the spurious designation in core, the > > interrupt line will be disabled while the TPM driver will think that it > > is still using IRQ mode and will not switch to polling. > > In the case that an interrupt storm cant be detected (since there might not even > be one) I am fine with adding a quirk.
Speaking of generic vs quirk (if storm can be detected): detection should be eager as ever possible. Too eager does not cause systems failing.
This way I think we can converge to stability fast as possible.
Then, later on, if a system where interrupts should work but the detection disables interrupts we can either make the fixed threshold less eager, or add a tuning parameter to sysfs.
BR, Jarkko
| |