lkml.org 
[lkml]   [2023]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 6/6] s390/uv: Update query for secret-UVCs
From
On 5/19/23 11:37, Steffen Eiden wrote:
> Update the query struct such that secret-UVC related
> information can be parsed.
> Add sysfs files for these new values.
>
> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>

You should add a bit of information about the fields.
Not a large amount but having no info doesn't help anyone without access
to our design documents.

> ---

[...]

> extern struct uv_info uv_info;
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index d5b5d7e83c17..c0a1bfb01135 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -571,6 +571,42 @@ static ssize_t uv_query_supp_att_pflags(struct kobject *kobj,
> static struct kobj_attribute uv_query_supp_att_pflags_attr =
> __ATTR(supp_att_pflags, 0444, uv_query_supp_att_pflags, NULL);
>
> +static ssize_t uv_query_supp_add_secret_req_ver(struct kobject *kobj,
> + struct kobj_attribute *attr, char *page)

s/page/buf/ for the whole lot.

> +{
> + return sysfs_emit(page, "%lx\n", uv_info.supp_add_secret_req_ver);
> +}
> +
> +static struct kobj_attribute uv_query_supp_add_secret_req_ver_attr =
> + __ATTR(supp_add_secret_req_ver, 0444, uv_query_supp_add_secret_req_ver, NULL);
> +
> +static ssize_t uv_query_supp_add_secret_pcf(struct kobject *kobj,
> + struct kobj_attribute *attr, char *page)
> +{
> + return sysfs_emit(page, "%lx\n", uv_info.supp_add_secret_pcf);
> +}
> +
> +static struct kobj_attribute uv_query_supp_add_secret_pcf_attr =
> + __ATTR(supp_add_secret_pcf, 0444, uv_query_supp_add_secret_pcf, NULL);
> +
> +static ssize_t uv_query_supp_secret_types(struct kobject *kobj,
> + struct kobj_attribute *attr, char *page)
> +{
> + return sysfs_emit(page, "%lx\n", uv_info.supp_secret_types);
> +}
> +
> +static struct kobj_attribute uv_query_supp_secret_types_attr =
> + __ATTR(supp_secret_types, 0444, uv_query_supp_secret_types, NULL);
> +

> +static ssize_t uv_query_max_secrets(struct kobject *kobj,
> + struct kobj_attribute *attr, char *page)
> +{
> + return sysfs_emit(page, "%d\n", uv_info.max_secrets);
> +}

uv_query_max_secrets
but then
uv_query_max_num_secrets_attr

To num or not to num. That's the question

> +
> +static struct kobj_attribute uv_query_max_num_secrets_attr =
> + __ATTR(max_secrets, 0444, uv_query_max_secrets, NULL);

And here the num is gone again.

> +
> static struct attribute *uv_query_attrs[] = {
> &uv_query_facilities_attr.attr,
> &uv_query_feature_indications_attr.attr,
> @@ -584,6 +620,10 @@ static struct attribute *uv_query_attrs[] = {
> &uv_query_dump_cpu_len_attr.attr,
> &uv_query_supp_att_req_hdr_ver_attr.attr,
> &uv_query_supp_att_pflags_attr.attr,
> + &uv_query_supp_add_secret_req_ver_attr.attr,
> + &uv_query_supp_add_secret_pcf_attr.attr,
> + &uv_query_supp_secret_types_attr.attr,
> + &uv_query_max_num_secrets_attr.attr,
> NULL,
> };
>

\
 
 \ /
  Last update: 2023-06-05 16:11    [W:0.151 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site