Messages in this thread | | | Date | Sun, 4 Jun 2023 21:41:25 -0700 | Subject | Re: [PATCH v8 10/12] crypto: x86/aesni - Use the proper data type in struct aesni_xts_ctx | From | "Chang S. Bae" <> |
| |
On 6/4/2023 7:46 PM, Eric Biggers wrote: > > IMO the issue is that your patch makes the code (including the XTS code) > inconsistent because it makes it use a mix of both approaches: it aligns each > field individually, *and* it aligns the ctx up-front.
But, the code did this already:
common_rfc4106_set_key() -> aesni_rfc4106_gcm_ctx_get(aead) // align ->ctx -> aes_set_key_common() -> aes_ctx() // here, this aligns again
And generic_gcmaes_set_key() as well.
Hmm, maybe a separate patch can spell out this issue more clearly for the record, no?
Thanks, Chang
| |