Messages in this thread | | | Date | Mon, 5 Jun 2023 14:23:03 -0700 | From | Isaku Yamahata <> | Subject | Re: [PATCH v11 07/20] x86/virt/tdx: Add skeleton to enable TDX on demand |
| |
On Mon, Jun 05, 2023 at 02:27:20AM +1200, Kai Huang <kai.huang@intel.com> wrote:
> diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h > index b489b5b9de5d..03f74851608f 100644 > --- a/arch/x86/include/asm/tdx.h > +++ b/arch/x86/include/asm/tdx.h > @@ -102,8 +102,12 @@ static inline long tdx_kvm_hypercall(unsigned int nr, unsigned long p1, > > #ifdef CONFIG_INTEL_TDX_HOST > bool platform_tdx_enabled(void); > +int tdx_cpu_enable(void); > +int tdx_enable(void); > #else /* !CONFIG_INTEL_TDX_HOST */ > static inline bool platform_tdx_enabled(void) { return false; } > +static inline int tdx_cpu_enable(void) { return -ENODEV; } > +static inline int tdx_enable(void) { return -ENODEV; } > #endif /* CONFIG_INTEL_TDX_HOST */ > > #endif /* !__ASSEMBLY__ */
Please include errno.h. In the case of !INTEL_TDX_HOST && INTEL_TDX_GUEST, drivers/virt/coco/tdx-guest/tdx-guest.c results in compile error.
Although there are other files that include asm/tdx.h, they seem to luckily include errno.h directly or indirectly. -- Isaku Yamahata <isaku.yamahata@gmail.com>
| |