lkml.org 
[lkml]   [2023]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] i2c: busses: i2c-nomadik: Remove a useless call in the remove function
    Date
    Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of
    git://git.pengutronix.de/git/wsa/linux"), there is no more
    request_mem_region() call in this driver.

    So remove the release_mem_region() call from the remove function which is
    likely a left over.

    There is no details in the above commit log, but at its end we can read:
    Conflicts:
    drivers/i2c/busses/i2c-nomadik.c

    This may explain why this call has been left here.

    Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    ---
    v2: synch with latest -next

    v1: https://lore.kernel.org/all/4f4c2c5c20b61c4bb28cb3e9ab4640534dd2adec.1629530169.git.christophe.jaillet@wanadoo.fr/


    /!\ /!\ /!\ /!\ /!\ /!\
    This patch is completely speculative and without details about commit
    a410963ba4c0 it's hard to be sure of the intent.
    /!\ /!\ /!\ /!\ /!\ /!\

    All I can say is that it looks logical to me and that it compiles!
    ---
    drivers/i2c/busses/i2c-nomadik.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
    index 1e5fd23ef45c..212f412f1c74 100644
    --- a/drivers/i2c/busses/i2c-nomadik.c
    +++ b/drivers/i2c/busses/i2c-nomadik.c
    @@ -1038,7 +1038,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)

    static void nmk_i2c_remove(struct amba_device *adev)
    {
    - struct resource *res = &adev->res;
    struct nmk_i2c_dev *dev = amba_get_drvdata(adev);

    i2c_del_adapter(&dev->adap);
    @@ -1047,7 +1046,6 @@ static void nmk_i2c_remove(struct amba_device *adev)
    clear_all_interrupts(dev);
    /* disable the controller */
    i2c_clr_bit(dev->virtbase + I2C_CR, I2C_CR_PE);
    - release_mem_region(res->start, resource_size(res));
    }

    static struct i2c_vendor_data vendor_stn8815 = {
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-06-30 23:24    [W:6.064 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site