Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 30 Jun 2023 16:57:52 +0300 | Subject | Re: [PATCH v1 5/5] gpiolib: Replace open coded gpiochip_irqchip_add_allocated_domain() |
| |
On Fri, Jun 30, 2023 at 2:52 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Jun 21, 2023 at 7:49 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > Replace open coded variant of gpiochip_irqchip_add_allocated_domain() > > in gpiochip_add_irqchip(). > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > and this concludes patches 4,5 very nicely as well.
Yep!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thank you for the review!
While at it, I would like to ask on ->to_irq() callback. IIUC assigning it with an IRQ chip makes a dead code in the driver. Am I correct? If not, can somebody shed some light on how the RT5677 driver, for example, works with GPIO IRQ?
-- With Best Regards, Andy Shevchenko
| |