Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 30 Jun 2023 16:41:57 -0700 | Subject | Re: [PATCH RFC v4 5/7] drm/msm/dpu: Add solid fill and pixel source properties | From | Jessica Zhang <> |
| |
On 6/29/2023 5:49 PM, Dmitry Baryshkov wrote: > On 30/06/2023 03:25, Jessica Zhang wrote: >> Add solid_fill and pixel_source properties to DPU plane >> >> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 ++ >> 1 file changed, 2 insertions(+) > > This should be the last commit.
Hi Dmitry,
Acked, will move this to the end.
Thanks,
Jessica Zhang
> Otherwise: > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >> index c2aaaded07ed..5f0984ce62b1 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >> @@ -1429,6 +1429,8 @@ struct drm_plane *dpu_plane_init(struct >> drm_device *dev, >> DPU_ERROR("failed to install zpos property, rc = %d\n", ret); >> drm_plane_create_alpha_property(plane); >> + drm_plane_create_solid_fill_property(plane); >> + drm_plane_create_pixel_source_property(plane, >> BIT(DRM_PLANE_PIXEL_SOURCE_COLOR)); >> drm_plane_create_blend_mode_property(plane, >> BIT(DRM_MODE_BLEND_PIXEL_NONE) | >> BIT(DRM_MODE_BLEND_PREMULTI) | >> > > -- > With best wishes > Dmitry >
| ![\](/images/icornerr.gif) |