Messages in this thread | | | From | Namhyung Kim <> | Date | Thu, 29 Jun 2023 14:31:34 -0700 | Subject | Re: [PATCH v2 00/12] Add metric has_event, update intel vendor events |
| |
Hi Ian,
On Fri, Jun 23, 2023 at 8:10 AM Ian Rogers <irogers@google.com> wrote: > > Add a new has_event function for metrics so that events that can be > disabled by the kernel/firmware don't cause metrics to fail. Use this > function for Intel transaction metrics fixing "perf all metrics test" > on systems with TSX disabled. The update conversion script is posted in: > https://github.com/intel/perfmon/pull/90 > > Re-generate Intel vendor events using: > https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py > Adding rocketlake support, uncore and many core events for meteorlake, > and smaller updates for cascakelakex, icelake, icelakex, > sapphirerapids, skylake, skylakex and tigerlake. > > v2. Handle failed memory allocated for evlist, John Garry. > > Ian Rogers (12): > perf expr: Add has_event function > perf jevents: Support for has_event function > perf vendor metrics intel: Make transaction metrics conditional > perf vendor events intel: Add rocketlake events/metrics > perf vendor events intel: Update meteorlake to 1.03 > perf vendor events intel: Update cascadelakex to 1.19 > perf vendor events intel: Update icelake to 1.19 > perf vendor events intel: Update icelakex to 1.21 > perf vendor events intel: Update sapphirerapids to 1.14 > perf vendor events intel: Update skylake to 57 > perf vendor events intel: Update skylakex to 1.31 > perf vendor events intel: Update tigerlake to 1.13
My tigerlake laptop now passes the all metrics test with this. It used to fail like below:
event syntax error: '{cpu/cycles-t,metric-id=cpu!3cycles!1t!3/,cpu/tx-start,m..' \___ unknown term 'cycles-t' for pmu 'cpu'
Tested-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
| |