Messages in this thread | | | Date | Thu, 29 Jun 2023 10:22:06 -0600 | From | Rob Herring <> | Subject | Re: [PATCH 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator |
| |
On Wed, Jun 28, 2023 at 06:29:45PM +0200, Konrad Dybcio wrote: > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > regulator, providing reference voltage to on-chip IP, like PHYs. > It's controlled through MMIO and we can toggle it or read its state back. > > Describe it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../regulator/qcom,sdm845-refgen-regulator.yaml | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml > new file mode 100644 > index 000000000000..19d3eb9db98f > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/qcom,sdm845-refgen-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. REFGEN Regulator > + > +maintainers: > + - Konrad Dybcio <konradybcio@kernel.org> > + > +description: |
Don't need '|'.
> + The REFGEN (reference voltage renegator) regulator provides reference
renegator?
> + voltage for on-chip IPs (like PHYs) on some Qualcomm SoCs. > + > +allOf: > + - $ref: regulator.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - qcom,sc7180-refgen-regulator > + - qcom,sc8180x-refgen-regulator > + - qcom,sm8150-refgen-regulator > + - const: qcom,sdm845-refgen-regulator > + > + - items: > + - enum: > + - qcom,sc7280-refgen-regulator > + - qcom,sc8280xp-refgen-regulator > + - qcom,sm6350-refgen-regulator > + - qcom,sm6375-refgen-regulator > + - qcom,sm8350-refgen-regulator > + - const: qcom,sm8250-refgen-regulator > + > + - enum: > + - qcom,sdm845-refgen-regulator > + - qcom,sm8250-refgen-regulator > + > + reg: true
Need to define how many.
> + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + regulator@162f000 { > + compatible = "qcom,sm8250-refgen-regulator"; > + reg = <0 0x0162f000 0 0x84>;
Default cell size is 1.
> + }; > +... > > -- > 2.41.0 >
| |