lkml.org 
[lkml]   [2023]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: core: Always store of_node when getting DAI link component
On Mon, Jun 26, 2023 at 12:49:16PM +0100, Mark Brown wrote:
> On Sun, Jun 25, 2023 at 11:54:29PM +0000, Kuninori Morimoto wrote:
>
> > > The generic snd_soc_dai_get_dlc() contains a default translation function
> > > for DAI names which has factored out common code in a number of card
> > > drivers, resolving the dai_name and of_node either using a driver provided
>
> > Yes, indeed.
> > But I think we want to set it under lock and if ret was no error case ?
>
> It doesn't really matter - there's only one possible result, and nothing
> should be looking at the dlc unless we return success, but yes that'd
> probably be a little cleaner providing we don't ever return early.

BTW that's not to say don't submit this as a patch, just that it doesn't
need to get applied as a fix.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-06-29 16:23    [W:0.048 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site