Messages in this thread | | | Date | Thu, 29 Jun 2023 07:28:28 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 1/3] blk-mq: always use __blk_mq_alloc_requests() to alloc and init rq |
| |
On Wed, Jun 28, 2023 at 08:45:44PM +0800, chengming.zhou@linux.dev wrote: > After these cleanup, __blk_mq_alloc_requests() is the only entry to > alloc and init rq.
I find the code a little hard to follow now, due to the optional setting of the ctx. We also introduce really odd behavior here if the caller for a hctx-specific allocation doesn't have free tags, as we'll now run into the normal retry path.
Is this really needed for your timestamp changes? If not I'd prefer to skip it.
| |