Messages in this thread | | | Date | Thu, 29 Jun 2023 11:45:25 +0300 | Subject | Re: [PATCH 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings | From | Dmitry Baryshkov <> |
| |
On 29/06/2023 04:19, Anjelique Melendez wrote: > > > On 6/26/2023 6:58 AM, Rob Herring wrote: >> On Wed, Jun 21, 2023 at 11:59:45AM -0700, Anjelique Melendez wrote: >>> Add binding for the Qualcomm Programmable Boot Sequencer device. >>> >>> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> >>> --- >>> .../bindings/soc/qcom/qcom-pbs.yaml | 41 +++++++++++++++++++ >>> 1 file changed, 41 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml >>> new file mode 100644 >>> index 000000000000..0a89c334f95c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml >>> @@ -0,0 +1,41 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/soc/qcom/qcom-pbs.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Technologies, Inc. PBS >>> + >>> +maintainers: >>> + - Anjelique Melendez <quic_amelende@quicinc.com> >>> + >>> +description: | >>> + Qualcomm PBS (programmable boot sequencer) supports triggering sequences >>> + for clients upon request. >>> + >>> +properties: >>> + compatible: >>> + const: qcom,pbs >>> + >>> + reg: >>> + description: | >>> + Base address of the PBS peripheral. >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + pmic { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + qcom,pbs@7400 { >>> + compatible = "qcom,pbs"; >>> + reg = <0x7400>; >>> + }; >> >> Why do you need a child node for this? Is there more than 1 instance in >> a PMIC? Every sub-function of a PMIC doesn't have to have a DT node. >> > > We currently have another downstream driver (which is planned to get upstreamed) > which also needs a handle to a pbs device in order to properly trigger events.
Does it have to be a separate driver? Or is it a part of the LPG driver, just being artificially split away?
> >> Rob > > >
-- With best wishes Dmitry
| |