| Date | Wed, 28 Jun 2023 17:42:53 +0300 | From | Andy Shevchenko <> | Subject | Re: [RFC PATCH 4/8] ALSA: hda/i915: Update PCI IDs |
| |
On Wed, Jun 28, 2023 at 10:51:31PM +0200, Amadeusz Sławiński wrote: > Use PCI device IDs from pci_ids.h header
Missing period at the end.
...
> -#define IS_HSW_CONTROLLER(pci) (((pci)->device == 0x0a0c) || \ > - ((pci)->device == 0x0c0c) || \ > - ((pci)->device == 0x0d0c) || \ > - ((pci)->device == 0x160c)) > +#define IS_HSW_CONTROLLER(pci) (((pci)->device == PCI_DEVICE_ID_INTEL_HDA_HSW_0) || \ > + ((pci)->device == PCI_DEVICE_ID_INTEL_HDA_HSW_2) || \ > + ((pci)->device == PCI_DEVICE_ID_INTEL_HDA_HSW_3) || \ > + ((pci)->device == PCI_DEVICE_ID_INTEL_HDA_BDW))
The very same macro under different name appeared in the previous patch. Am I correct? Perhaps go further and first move it somewhere to be available for both?
-- With Best Regards, Andy Shevchenko
|