Messages in this thread | | | Date | Wed, 28 Jun 2023 17:38:39 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] crypto: qat - use min() in fw loader |
| |
On Wed, Jun 28, 2023 at 02:11:53PM +0100, Giovanni Cabiddu wrote: > On Wed, Jun 28, 2023 at 01:46:44PM +0300, Andy Shevchenko wrote: > > On Tue, Jun 27, 2023 at 03:17:24PM +0800, You Kangren wrote:
...
> > min_t() can be dangerous some times. > > > > To make it robust I would suggest to use min() and mark UWORD_CPYBUF_SIZE > > with U suffix to make the type the same. > Thanks. I reworked it, added a missing include and ordered the includes > in the file.
I think it should be two patches then, but it's up to you and subsystem maintainer.
-- With Best Regards, Andy Shevchenko
| |