Messages in this thread | | | Date | Tue, 27 Jun 2023 18:42:48 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v1 7/9] RISC-V: split riscv_fill_hwcap() in 3 |
| |
On Mon, Jun 26, 2023 at 06:17:51PM +0200, Andrew Jones wrote: > > +void __init riscv_fill_hwcap(void) > > +{ > > + struct device_node *node; > > + const char *isa; > > + char print_str[NUM_ALPHA_EXTS + 1]; > > + int i, j, rc; > > + unsigned long isa2hwcap[26] = {0}; > > + struct acpi_table_header *rhct; > > + acpi_status status; > > + unsigned int cpu; > > I see all these unused variables get removed in the next patch, but they > should get removed here, lest they trigger some warnings and bots come > after you!
Funnily enough, I'd pushed this out for LKP and it never complained about the unused variables - but my own stuff on patchwork did. [unhandled content-type:application/pgp-signature] | |