Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [RFC PATCH 0/2] Resctrl - rewrite (WIP) | Date | Tue, 27 Jun 2023 16:33:52 +0000 |
| |
>> By itself the core code is useless. Cannot even be built as the >> controlling Kconfig option "CONFIG_RESCTRL2_FS" must be invoked by >> a "select" request from architecture specific code that provides >> the necessary "arch_*()" functions to make everything work. > > I would like to try to rebase the RISC-V CBQRI resctrl RFC [1] on top of > this patch series instead of the mpam snapshot branch [2].
Thanks. That should help shake out any places where I've left in Intel-isms, or my abstraction is insufficient to handle your architecture.
I've made some significant changes since I posted those patches. I pushed the latest version to:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git resctrl2_v64
> I had a patch in my RFC that added config option RISCV_ISA_SSQOSID which > selects ARCH_HAS_CPU_RESCTRL and RESCTRL_FS [3]. It seems I would need > to change that to select CONFIG_RESCTRL2_FS ?
Yes. Just have your architecture CONFIG option select RESCTRL2_FS
> A patch [4] in that RFC adds the "arch_*()" functions in > arch/riscv/kernel/qos/qos_resctrl.c
Yes. This is an area that may need some tweaking to get the prototypes for the arch_*() functions right.
I put all the x86 architecture code under fs/resctrl2/arch/x86/ .... mostly so I can do quick test builds of both the common code and architecture code with "make fs/resctrl2/" ... maybe in the end-game they should be under arch/x86 rather than adding arch specific subdirs under generic top-level directories (though I see a smattering of "x86" directories in several places.
-Tony
| |