Messages in this thread | | | Date | Tue, 27 Jun 2023 17:11:15 +0200 | From | Simon Horman <> | Subject | Re: [PATCH v2 net-next] net: phy: mscc: fix packet loss due to RGMII delays |
| |
On Tue, Jun 27, 2023 at 04:42:35PM +0300, Vladimir Oltean wrote: > Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII > if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps" > override exists. The negative error code from phy_get_internal_delay() > does not get overridden with the delay deduced from the phy-mode, and > later gets committed to hardware. Also, the rx_delay gets overridden by > what should have been the tx_delay. > > Fixes: dbb050d2bfc8 ("phy: mscc: Add support for RGMII delay configuration") > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Reviewed-by: Harini Katakam <harini.katakam@amd.com> > --- > v1->v2: resend to net-next
Patch looks good.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Though, TBH, I'm unsure what the correct tree is at this point.
| |