Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH v2] block: add check that partition length needs to be aligned with block size | Date | Tue, 27 Jun 2023 04:19:41 +0000 |
| |
On 6/27/2023 4:09 AM, Min Li wrote: > Before calling add partition or resize partition, there is no check > on whether the length is aligned with the logical block size. > If the logical block size of the disk is larger than 512 bytes, > then the partition size maybe not the multiple of the logical block size, > and when the last sector is read, bio_truncate() will adjust the bio size, > resulting in an IO error if the size of the read command is smaller than > the logical block size.If integrity data is supported, this will also > result in a null pointer dereference when calling bio_integrity_free. > > Signed-off-by: Min Li <min15.li@samsung.com> > > --- > Changes from v1: > > - Add a space after /* and before */. > - Move length alignment check before the "start = p.start >> SECTOR_SHIFT" > - Move check for p.start being aligned together with this length alignment check. > ---
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
| |