Messages in this thread | | | Subject | Re: [PATCH net] net: phy: mscc: fix packet loss due to RGMII delays | From | Paolo Abeni <> | Date | Tue, 27 Jun 2023 14:47:22 +0200 |
| |
On Tue, 2023-06-27 at 15:13 +0300, Vladimir Oltean wrote: > On Tue, Jun 27, 2023 at 12:11:09PM +0300, Vladimir Oltean wrote: > > Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII > > if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps" > > override exists. The negative error code from phy_get_internal_delay() > > does not get overridden with the delay deduced from the phy-mode, and > > later gets committed to hardware. Also, the rx_delay gets overridden by > > what should have been the tx_delay. > > > > Fixes: dbb050d2bfc8 ("phy: mscc: Add support for RGMII delay configuration") > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > --- > > I may have mis-targeted this patch towards "net" while the "net-next" > pull request has not been yet sent out. Can patchwork be instructed to > re-run the tests on net-next?
I'm not 110% sure, but I think you have to re-send the patch with a different prefix to achieve the above.
Cheers,
Paolo >
| |