Messages in this thread | | | Date | Tue, 27 Jun 2023 18:09:31 +0700 | From | Bagas Sanjaya <> | Subject | Re: [PATCH] staging: ks7010: Wrap macro definitions in parenthesis |
| |
On Wed, Jun 16, 2021 at 09:26:03PM +0000, Caleb D.S. Brzezinski wrote: > /* 11b rate */ > -#define TX_RATE_1M (u8)(10 / 5) /* 11b 11g basic rate */ > -#define TX_RATE_2M (u8)(20 / 5) /* 11b 11g basic rate */ > -#define TX_RATE_5M (u8)(55 / 5) /* 11g basic rate */ > -#define TX_RATE_11M (u8)(110 / 5) /* 11g basic rate */ > +#define TX_RATE_1M ((u8)(10 / 5)) /* 11b 11g basic rate */ > +#define TX_RATE_2M ((u8)(20 / 5)) /* 11b 11g basic rate */ > +#define TX_RATE_5M ((u8)(55 / 5)) /* 11g basic rate */ > +#define TX_RATE_11M ((u8)(110 / 5)) /* 11g basic rate */ > > /* 11g rate */ > -#define TX_RATE_6M (u8)(60 / 5) /* 11g basic rate */ > -#define TX_RATE_12M (u8)(120 / 5) /* 11g basic rate */ > -#define TX_RATE_24M (u8)(240 / 5) /* 11g basic rate */ > -#define TX_RATE_9M (u8)(90 / 5) > -#define TX_RATE_18M (u8)(180 / 5) > -#define TX_RATE_36M (u8)(360 / 5) > -#define TX_RATE_48M (u8)(480 / 5) > -#define TX_RATE_54M (u8)(540 / 5) > +#define TX_RATE_6M ((u8)(60 / 5)) /* 11g basic rate */ > +#define TX_RATE_12M ((u8)(120 / 5)) /* 11g basic rate */ > +#define TX_RATE_24M ((u8)(240 / 5)) /* 11g basic rate */ > +#define TX_RATE_9M ((u8)(90 / 5)) > +#define TX_RATE_18M ((u8)(180 / 5)) > +#define TX_RATE_36M ((u8)(360 / 5)) > +#define TX_RATE_48M ((u8)(480 / 5)) > +#define TX_RATE_54M ((u8)(540 / 5)) >
tl;dr (quoted from Greg's bot):
> You sent a patch that has been sent multiple times in the past few > days, and is identical to ones that has been recently rejected. > Please always look at the mailing list traffic to determine if you are > duplicating other people's work.
Why? See discussions on [1] and [2].
[1]: https://lore.kernel.org/all/YCUAy1VhLV3lwa3H@kroah.com/ [2]: https://lore.kernel.org/all/20210222062849.GN2087@kadam/
Thanks.
-- An old man doll... just what I always wanted! - Clara [unhandled content-type:application/pgp-signature] | |