lkml.org 
[lkml]   [2023]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH v6 08/13] iio: inkern: Use max_array() to get the maximum value from an array
Date


Le 23/06/2023 à 10:58, Herve Codina a écrit :
> Use max_array() to get the maximum value from an array instead of a
> custom local loop.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> drivers/iio/inkern.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index 71d0424383b6..8bfd91f74101 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -5,6 +5,7 @@
> */
> #include <linux/err.h>
> #include <linux/export.h>
> +#include <linux/minmax.h>
> #include <linux/mutex.h>
> #include <linux/property.h>
> #include <linux/slab.h>
> @@ -875,11 +876,7 @@ static int iio_channel_read_max(struct iio_channel *chan,
> return -EINVAL;
> switch (*type) {
> case IIO_VAL_INT:
> - *val = vals[--length];
> - while (length) {
> - if (vals[--length] > *val)
> - *val = vals[length];
> - }
> + *val = max_array(vals, length);
> break;
> default:
> /* FIXME: learn about max for other iio values */
\
 
 \ /
  Last update: 2023-06-27 12:01    [W:0.153 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site