lkml.org 
[lkml]   [2023]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [12/39] drm: renesas: shmobile: Don't set display info width and height twice
From
Hi

On 2023/6/22 17:21, Geert Uytterhoeven wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> The display info width_mm and height_mm fields are set at init time and
> never overwritten, don't set them a second time when getting modes.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> index c775c1d49f0e1ce9..0eeb1410b662d74b 100644
> --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> @@ -618,9 +618,6 @@ static int shmob_drm_connector_get_modes(struct drm_connector *connector)
> drm_mode_set_name(mode);
> drm_mode_probed_add(connector, mode);
>
> - connector->display_info.width_mm = sdev->pdata->panel.width_mm;
> - connector->display_info.height_mm = sdev->pdata->panel.height_mm;
> -
> return 1;
> }
>

--
Jingfeng

\
 
 \ /
  Last update: 2023-06-28 03:47    [W:0.327 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site