Messages in this thread | | | Date | Wed, 28 Jun 2023 09:16:46 +0800 | Subject | Re: [PATCH v2 3/3] blk-mq: fix start_time_ns and alloc_time_ns for pre-allocated rq | From | Chengming Zhou <> |
| |
On 2023/6/28 02:47, Tejun Heo wrote: > Hello, > > On Tue, Jun 27, 2023 at 07:32:42PM +0800, Chengming Zhou wrote: >> Since all requests in batch allocation use the same alloc and start time, so this patch >> just leave it as it is, and reset it at actual used time. >> >> I think both way is ok, do you think it's better to just set the popped one request, leave >> other requests time to 0 ? If so, I can update to do it. > > I think it'd be clearer if the rule is that the alloc time is set once when > the request is actually dispensed for use in all cases, so yeah, let's just > set it once when it actually starts getting used. >
Good, I will update the patchset today.
Thanks.
| |