lkml.org 
[lkml]   [2023]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v12 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand
On Tue, Jun 27, 2023 at 10:37:58PM +0000,
"Huang, Kai" <kai.huang@intel.com> wrote:

> > >
> > > +/*
> > > + * Do the module global initialization if not done yet.
> > > + * It's always called with interrupts and preemption disabled.
> > > + */
> >
> > If interrupts are always disabled why do you need _irqsave()?
> >
>
> I'll remove the _irqsave().
>
> AFAICT Isaku preferred this for additional security, but this is not necessary.

It's because the lockdep complains. Anyway, it's save to remove _irqsave as
discussed with you.
--
Isaku Yamahata <isaku.yamahata@gmail.com>

\
 
 \ /
  Last update: 2023-06-28 02:32    [W:0.238 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site