lkml.org 
[lkml]   [2023]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/5] dt-bindings: pps: pps-gpio: introduce capture-clear property
    From
    On 25/06/2023 16:21, Eliav Farber wrote:
    > Add a new optional "capture-clear" boolean property.
    > When present, PPS clear events shall also be reported.
    >
    > Signed-off-by: Eliav Farber <farbere@amazon.com>
    > ---
    > Documentation/devicetree/bindings/pps/pps-gpio.txt | 4 ++++

    Please convert the bindings to DT schema first.

    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt b/Documentation/devicetree/bindings/pps/pps-gpio.txt
    > index 9012a2a02e14..8d588e38c44e 100644
    > --- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
    > +++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
    > @@ -14,6 +14,10 @@ Additional required properties for the PPS ECHO functionality:
    > Optional properties:
    > - assert-falling-edge: when present, assert is indicated by a falling edge
    > (instead of by a rising edge)
    > +- capture-clear: when present, report also PPS clear events, which is the
    > + opposite of the assert edge (if assert is rising-edge then
    > + clear is falling-edge and if assert is falling-edge then
    > + clear is rising-edge).

    Why this is board-dependant? Falling edge is happening anyway, so it is
    in the hardware all the time. DT describes the hardware, not Linux
    driver behavior.

    What's more, your property name sounds a lot like a driver property, so
    even if this is suitable for DT, you would need to name it properly to
    match hardware feature/characteristic.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-06-25 17:47    [W:3.431 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site