Messages in this thread | | | Date | Sun, 25 Jun 2023 15:41:41 +0300 | Subject | Re: [PATCH v6 3/3] drm/virtio: Support sync objects | From | Dmitry Osipenko <> |
| |
On 6/25/23 11:47, Geert Uytterhoeven wrote: > Hi Dmitry, > > On Sun, Apr 16, 2023 at 1:55 PM Dmitry Osipenko > <dmitry.osipenko@collabora.com> wrote: >> Add sync object DRM UAPI support to VirtIO-GPU driver. Sync objects >> support is needed by native context VirtIO-GPU Mesa drivers, it also will >> be used by Venus and Virgl contexts. >> >> Reviewed-by; Emil Velikov <emil.velikov@collabora.com> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > > Thanks for your patch! > >> --- a/drivers/gpu/drm/virtio/virtgpu_submit.c >> +++ b/drivers/gpu/drm/virtio/virtgpu_submit.c > >> +static int >> +virtio_gpu_parse_deps(struct virtio_gpu_submit *submit) >> +{ >> + struct drm_virtgpu_execbuffer *exbuf = submit->exbuf; >> + struct drm_virtgpu_execbuffer_syncobj syncobj_desc; >> + size_t syncobj_stride = exbuf->syncobj_stride; >> + u32 num_in_syncobjs = exbuf->num_in_syncobjs; >> + struct drm_syncobj **syncobjs; >> + int ret = 0, i; >> + >> + if (!num_in_syncobjs) >> + return 0; >> + >> + /* >> + * kvalloc at first tries to allocate memory using kmalloc and >> + * falls back to vmalloc only on failure. It also uses GFP_NOWARN > > GFP_NOWARN does not exist.
https://elixir.bootlin.com/linux/v6.4-rc7/source/include/linux/gfp_types.h#L38
-- Best regards, Dmitry
| |