lkml.org 
[lkml]   [2023]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9] can: usb: IXXAT USB-to-CAN adapters drivers
Hello Eric,

On Mon, 19 Jun 2023 10:25:27 -0400, Eric Stahl <ericstahl@limntech.com> wrote:

> Hi all,
>
> The socketcan@hms-networks.de is bouncing for me. I removed both Florian
> Ferg's email (flfe@hms-networks.de) and sockectcan@hms-networks.de. I
> saw Markus from hms commenting on the last thread (PATCH v8) resolving
> those issues, so I've added him to this chain. I'm not sure if they are
> still a problem.
>
> I've backported Peter's PATCH v9 and it works well for me. It seems that

Thanks for testing effort ;-)

> hms is distributing a driver that does not incorporate the proposed
> changes from the past reviews
> (https://forum.hms-networks.com/t/socketcan-driver-for-linux-20-04/70299/30).
> Their driver has not worked for me with higher level CANopen libraries,

From a quick look at the provided sources they seem to (at least) lack the
following fix 'can: ixxat_usb: do not free skb before last usage'
(which was needed for my CAN FD use case to work with the HMS provided
sources):

https://codeberg.org/psreport/socketcan-linux-ix-usb-can/commit/51b3021

> but Peter's v8/v9 and Florian's past contributions work well. I would
> like to get ixxat's active pci socketcan drivers pulled into the mainline.
>

Not on my agenda (as I have only access to USB-to-CAN FD hardware at the
moment)...

> I don't mean to hijack this thread, but I was wondering if it's
> appropriate to add those pci drivers to this patch to get reviewed, or
> if it's more appropriate to open a separate patch.

I think best is to provide it as a separate patch as a starting point...

Regards,
Peter

>
> Thanks,
>
> Eric





\
 
 \ /
  Last update: 2023-06-23 14:11    [W:0.102 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site