Messages in this thread | | | From | <> | Subject | RE: [PATCH v6 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings | Date | Wed, 21 Jun 2023 09:01:34 +0000 |
| |
Hello Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, June 20, 2023 3:55 PM > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > <yuji2.ishikawa@toshiba.co.jp>; Hans Verkuil <hverkuil@xs4all.nl>; Sakari > Ailus <sakari.ailus@iki.fi>; Laurent Pinchart > <laurent.pinchart@ideasonboard.com>; Mauro Carvalho Chehab > <mchehab@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > <conor+dt@kernel.org>; iwamatsu nobuhiro(岩松 信洋 ○DITC□DIT○ > OST) <nobuhiro1.iwamatsu@toshiba.co.jp> > Cc: linux-media@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v6 1/5] dt-bindings: media: platform: visconti: Add Toshiba > Visconti Video Input Interface bindings > > On 20/06/2023 05:11, Yuji Ishikawa wrote: > > Adds the Device Tree binding documentation that allows to describe the > > Video Input Interface found in Toshiba Visconti SoCs. > > > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > > --- > > Changelog v2: > > - no change > > > > Changelog v3: > > - no change > > > > Changelog v4: > > - fix style problems at the v3 patch > > - remove "index" member > > - update example > > > > Changelog v5: > > - no change > > > > Changelog v6: > > - add register definition of BUS-IF and MPU > > You ignored the comments from v4->v5. I pointed this out. You still ignored > them. > > You keep sending the same wrong patch ignoring review. This is not acceptable. > > NAK
I'm sorry for forgetting applying advice for v4 and v5 patches to this submission. I'll add following changes to the v7 patch.
* Remove trailing "bindings" at the commit header, as "dt-bindings:" is already set. * Remove trailing "Device Tree Bindings" from the title. * Fix text wrappings of the description * Update compatible to "toshiba,visconti5-viif" * Update clock-lanes.description "s/line/lane/" * the same with data-lanes.description * remove "unevaluatedProperty:false" from endpoint. put "additionalProperties:false" instead.
> Best regards, > Krzysztof
Best regards, Yuji Ishikawa
| |