Messages in this thread | | | Date | Wed, 21 Jun 2023 18:46:23 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: stmpe: Fix a corner case in stmpe_probe() |
| |
On Sat, 17 Jun 2023, Christophe JAILLET wrote:
> In stmpe_probe(), if some regulator_enable() calls fail, probing continues > and there is only a dev_warn(). > > So, if stmpe_probe() is called the regulator may not be enabled. It is > cleaner to test it before calling regulator_disable() in the remove > function. > > Fixes: 9c9e321455fb ("mfd: stmpe: add optional regulators") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/mfd/stmpe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
-- Lee Jones [李琼斯]
| |