Messages in this thread | | | Date | Wed, 21 Jun 2023 10:46:17 -0600 | From | Keith Busch <> | Subject | Re: [PATCH v2] nvme: Print capabilities changes just once |
| |
On Thu, Jun 15, 2023 at 02:49:03AM -0700, Breno Leitao wrote: > if (effects & NVME_CMD_EFFECTS_CCC) { > - dev_info(ctrl->device, > + if (!test_and_set_bit(NVME_CTRL_DIRTY_CAPABILITY, > + &ctrl->flags)) { > + dev_info(ctrl->device, > "controller capabilities changed, reset may be required to take effect.\n"); > + } > }
Thanks, patch applied to nvme-6.5.
A question for Christoph and future consideration: I *think* the complications that had the driver stop refreshing the controller attributes are largely mitigated by the fact we now handle effects after the request is freed. Perhaps I'm missing something. Is there a risk in just bringing that feature back into the driver?
| |