lkml.org 
[lkml]   [2023]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] mm/swapfile: delete outdated pte_offset_map() comment
    Delete a triply out-of-date comment from add_swap_count_continuation():
    1. vmalloc_to_page() changed from pte_offset_map() to pte_offset_kernel()
    2. pte_offset_map() changed from using kmap_atomic() to kmap_local_page()
    3. kmap_atomic() changed from using fixed FIX_KMAP addresses in 2.6.37.

    Signed-off-by: Hugh Dickins <hughd@google.com>
    ---
    Here's a late "33/32" to the series just moved to mm-stable - thank you!

    mm/swapfile.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/mm/swapfile.c b/mm/swapfile.c
    index 12d204e6dae2..0a17d85b50cb 100644
    --- a/mm/swapfile.c
    +++ b/mm/swapfile.c
    @@ -3470,11 +3470,6 @@ int add_swap_count_continuation(swp_entry_t entry, gfp_t gfp_mask)
    goto out;
    }

    - /*
    - * We are fortunate that although vmalloc_to_page uses pte_offset_map,
    - * no architecture is using highmem pages for kernel page tables: so it
    - * will not corrupt the GFP_ATOMIC caller's atomic page table kmaps.
    - */
    head = vmalloc_to_page(si->swap_map + offset);
    offset &= ~PAGE_MASK;

    --
    2.35.3
    \
     
     \ /
      Last update: 2023-06-20 08:50    [W:6.562 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site