Messages in this thread | | | Date | Tue, 20 Jun 2023 15:59:53 +0200 | From | Andrew Lunn <> | Subject | Re: [net-next PATCH v4 0/3] leds: trigger: netdev: add additional modes |
| |
> > If you do decided to wait, you are going to need to create another > > stable branch to pull into netdev. I know it is not a huge overhead, > > but it is still work, coordination etc. > > Can you clarify you last point for me please?
This patchset extends the conditions on which the trigger blinks the LED. It adds a couple more values to enum led_trigger_netdev_modes in include/linux/leds.h. Once it gets merged, i will have a followup patch extending the Marvell PHY driver to make us of them. It will need these additional enum values. I also expect other PHY drivers to gain support for them. Probably the dp83867.c driver since Alexander Stein already has a patch merged adding support for what the current API supports.
If we merge this patchset now via netdev, -rc1 should have everything we need for this continuing development work. If we wait to merge these patches until -rc1, only the LED tree has the needed patches, so these network drivers will need a stable branch we can pull into netdev.
Both ways work, we can do either. But it is probably easier for everybody to merge now via netdev.
Andrew
| |