Messages in this thread | ![/](/images/icornerl.gif) | | From | Thomas Gleixner <> | Subject | Re: [patch v3 6/7] x86/smp: Split sending INIT IPI out into a helper function | Date | Tue, 20 Jun 2023 14:30:45 +0200 |
| |
On Tue, Jun 20 2023 at 11:29, Borislav Petkov wrote: > On Thu, Jun 15, 2023 at 10:33:58PM +0200, Thomas Gleixner wrote: >> >> -static int >> -wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) >> +static void send_init_sequence(int phys_apicid) >> { >> - unsigned long send_status = 0, accept_status = 0; >> - int maxlvt, num_starts, j; >> - >> - maxlvt = lapic_get_maxlvt(); >> + int maxlvt = lapic_get_maxlvt(); > > Whoops: > > arch/x86/kernel/smpboot.c: In function ‘send_init_sequence’: > arch/x86/kernel/smpboot.c:860:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > 860 | int maxlvt = lapic_get_maxlvt(); > | ^~~
How so? It's the first thing in the function, no?
And in the other hunk it's _before_ code too.
Conflict resolution artifact?
Thanks,
tglx
| ![\](/images/icornerr.gif) |