lkml.org 
[lkml]   [2023]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling
On Mon, 19 Jun 2023 16:28:51 +0300 Radu Pirea (NXP OSS) wrote:
> Subject: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling

typo: enablig -> enabling

> .config_intr() handles only the link event interrupt and should
> disable/enable the PTP interrupt also.

I don't understand this sentence, TBH, could you rephrase?

> Fixes: 514def5dd339 ("phy: nxp-c45-tja11xx: add timestamping support")

For a fix we really need to commit message to say what the problem is,
in terms which will be understood by the user. User visible behavior.

> CC: stable@vger.kernel.org # 5.15+
> Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com>
> ---
>
> Where is V1?
> https://patchwork.kernel.org/project/netdevbpf/patch/20230410124856.287753-1-radu-nicolae.pirea@oss.nxp.com/
>
> Where is V2?
> https://patchwork.kernel.org/project/netdevbpf/patch/20230616135323

This link looks cut off.

> + /* 0x807A register is not present on SJA1110 PHYs. */

Meaning? It's safe because the operation will be ignored?
--
pw-bot: cr

\
 
 \ /
  Last update: 2023-06-21 05:32    [W:0.056 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site